Merged
Conversation
This was referenced Dec 26, 2024
ahcorde
requested changes
Dec 26, 2024
Contributor
ahcorde
left a comment
ahcorde
left a comment
There was a problem hiding this comment.
Do you mind to sign the commit https://github.com/gazebosim/gz-sensors/pull/491/checks?check_run_id=34883433200 ?
Signed-off-by: Utkarsh <Utkarsh.Yenurkar@Sony.com>
Signed-off-by: Utkarsh <Utkarsh.Yenurkar@Sony.com>
BA-Utkarsh
force-pushed
the
gz-sensors9-v1
branch
from
a455c61 to
8200848
Compare
Contributor
Author
@ahcorde , done. |
ahcorde
requested changes
Jan 10, 2025
Contributor
ahcorde
left a comment
ahcorde
left a comment
There was a problem hiding this comment.
please check linters
/github/workspace/src/LogicalCameraSensor.cc:185: Lines should be <= 80 characters long [whitespace/line_length] [2]
/github/workspace/src/LogicalCameraSensor.cc:195: Lines should be <= 80 characters long [whitespace/line_length] [2]
/github/workspace/src/LogicalCameraSensor.cc:196: Lines should be <= 80 characters long [whitespace/line_length] [2]
Signed-off-by: Utkarsh <Utkarsh.Yenurkar@Sony.com>
ahcorde
approved these changes
Jan 13, 2025
iche033
reviewed
Jan 16, 2025
Contributor
iche033
left a comment
iche033
left a comment
There was a problem hiding this comment.
thanks for the contribution. Just minor comments.
src/LogicalCameraSensor.cc
Outdated
| /// \brief node to create publisher | ||
| public: transport::Node node; | ||
|
|
||
| public: transport::Node node_logic; |
src/LogicalCameraSensor.cc
Outdated
| /// \brief Msg containg info on models detected by logical camera | ||
| msgs::LogicalCameraImage msg; | ||
|
|
||
| msgs::LogicalCameraSensor msg_logic; |
Contributor
There was a problem hiding this comment.
Suggested change
| msgs::LogicalCameraSensor msg_logic; | |
| /// \brief Msg containing logical camera frustum info. | |
| public: msgs::LogicalCameraSensor msgLogic; |
Looks like we forgot to add public to msg above as well.
src/LogicalCameraSensor.cc
Outdated
| /// \brief publisher to publish logical camera messages. | ||
| public: transport::Node::Publisher pub; | ||
|
|
||
| public: transport::Node::Publisher pub_logic; |
Contributor
There was a problem hiding this comment.
use camelCase and add doxygen comment:
Suggested change
| public: transport::Node::Publisher pub_logic; | |
| /// \brief Publisher to publish logical camera frustum information | |
| public: transport::Node::Publisher pubLogic; |
src/LogicalCameraSensor.cc
Outdated
|
|
||
| if (!this->dataPtr->pub_logic) | ||
| { | ||
| gzerr << "Unable to create publisher on topic[" << this->Topic() << "].\n"; |
Contributor
There was a problem hiding this comment.
Suggested change
| gzerr << "Unable to create publisher on topic[" << this->Topic() << "].\n"; | |
| gzerr << "Unable to create publisher on topic[" << this->Topic() << "/frustum].\n"; |
Signed-off-by: Utkarsh <Utkarsh.Yenurkar@Sony.com>
Signed-off-by: Utkarsh <Utkarsh.Yenurkar@Sony.com>
BA-Utkarsh
force-pushed
the
gz-sensors9-v1
branch
from
c21162d to
7ccc96f
Compare
iche033
approved these changes
Jan 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
This PR mainly adds the visualization of Frustum.
We could see it was present in gazebo classic and from gazebo garden onwards the plugin/feature is not available.
Test it
$ Build gazebo from source.
$ . install/setup.sh
$ gz sim examples/worlds/visualize_frustum.sdf
Test Ref images,
Play the simulation.
Select the topic from scroll down.
Refresh it to get the "logical_camera/frustum" topic.
Subcriibed to "logical_camera/frustum".
Final output
Checklist
codecheckpassedSupporting PRs